[Mono-devel-list] [PATCH] SslCipherSuite sequence #

[Sébastien Pouliot]

Brian patch, if applied on SVN, is identical on the results.
I'll apply it to SVN.

Sebastien Pouliot
home: spouliot at videotron.ca
blog: http://pages.infinit.net/ctech/poupou.html


> -----Original Message-----
> From: Carlos Guzmán Álvarez [mailto:carlosga at telefonica.net]
> Sent: 5 avril 2005 09:19
> To: spouliot at videotron.ca
> Cc: Brian Ritchie; mono-devel-list at lists.ximian.com
> Subject: Re: [Mono-devel-list] [PATCH] SslCipherSuite sequence #
>
>
> Hello:
>
> >If Carlos is also ok on the patch then it will be committed shortly.
> >
> I think the patch should look like the above one(sorry for send it in
> CVS format), what will left that code as in the TlsCipherSuite.
>
> ( I have tested it against PostgreSQL 8.0 using SSL3. )
>
> Opinions ??
>
>
>
> Index: SslCipherSuite.cs
> ===================================================================
> RCS file:
> /cvsroot/pgsqlclient/pgsqlclient_10/Mono.Security/Mono.Security/Mo
> no.Security.Protocol.Tls/SslCipherSuite.cs,v
> retrieving revision 1.7
> diff -u -r1.7 SslCipherSuite.cs
> --- SslCipherSuite.cs    5 Apr 2005 13:01:02 -0000    1.7
> +++ SslCipherSuite.cs    5 Apr 2005 13:16:22 -0000
> @@ -80,14 +80,16 @@
>
>              block.Write(this.Context.ServerWriteMAC);
>              block.Write(this.pad1);
> +
>              if (this.Context is ClientContext)
>              {
> -                block.Write(this.Context.WriteSequenceNumber);
> +                block.Write(this.Context.ReadSequenceNumber);
>              }
>              else
>              {
> -                block.Write(this.Context.ReadSequenceNumber);
> +                block.Write(this.Context.WriteSequenceNumber);
>              }
> +
>              block.Write((byte)contentType);
>              block.Write((short)fragment.Length);
>              block.Write(fragment);
> @@ -116,14 +118,16 @@
>
>              block.Write(this.Context.ClientWriteMAC);
>              block.Write(this.pad1);
> +
>              if (this.Context is ClientContext)
>              {
> -                block.Write(this.Context.ReadSequenceNumber);
> +                block.Write(this.Context.WriteSequenceNumber);
>              }
>              else
>              {
> -                block.Write(this.Context.WriteSequenceNumber);
> +                block.Write(this.Context.ReadSequenceNumber);
>              }
> +
>              block.Write((byte)contentType);
>              block.Write((short)fragment.Length);
>              block.Write(fragment);
>
> ***** CVS exited normally with code 1 *****
>
>
>
> --
> Best regards
>
> Carlos Guzmán Álvarez
> Vigo-Spain
>
> "Todos somos muy ignorantes. Lo que ocurre
> es que no todos ignoramos las mismas cosas." Albert Einstein
>