[Mono-devel-list] [PATCH, RFA] mono: Fix for module handling in dynamic assemblies

[Zoltan Varga]

On Tue, 28 Sep 2004 18:46:51 +0530, Raja R Harinath
<rharinath at novell.com> wrote:
> Hi,
> 
> Zoltan Varga <vargaz at gmail.com> writes:
> 
> > On Tue, 28 Sep 2004 13:09:37 +0530, Raja R Harinath <rharinath at novell.com> wrote:
> >
> >> This patch fixes an issue uncovered by mcs/tests/module-{1,2,3}.cs.
> >> It ensures that image->modules is updated when we add references to
> >> modules in dynamic assemblies.
> >>
> >> Ok to apply.
> >
> >   This is ok to check in.
> 
> Here's a followup patch to icall_SRA_GetModuleInternal.   Ok to apply?
> 

This is ok to check in.

> Also, should modules that are both in the FILES and MODULEREF tables be
> listed twice in the output as two _different_ objects that share the
> same MonoImage *?  IOW, should in the second loop below, should we skip
> file objects with ->image != NULL?  (I don't have a Windows machine
> handy to check the behaviour.)
> 

No idea.  If the current behavior becomes a problem, we can change it.

                              Zoltan

> - Hari
> 
> 
> 
>