[Mono-devel-list] gtk-sharp patch for DllImport mappings

[Mike Kestner]

On Fri, 2004-05-21 at 11:42, Urs Muff wrote:
> Sorry for the list mismatch, but I don't know all the lists there are.
> 
> But shouldn't that be done in the config file rather the in the DllImport
> attribute?  I don't see a reason why the DllImport attribute needs to be
> that specific.  I my opinion having glib-2.0 rather then libglib-2.0-0.dll
> in the DllImport attribute is more generic and portable.

A couple comments:

First, patches should have a ChangeLog.  Ideally, your mail should
indicate what problem your patch is addressing too.  If I were to guess,
it would be that there's a problem with gobject library access on OSX,
but I'm unsure how the patch you proposed would necessarily solve that
problem.

Second, your patch can't be accepted.  The DllImport library names in
the Gtk# source correspond to the library names on win32 for all the
libraries that are supported on win32.  They have to be this way to work
on the MS runtime.  We have a mapping mechanism via config files on mono
that can be used to map the win32 name to naming conventions on other
platforms.

-- 
Mike Kestner <mkestner at ximian.com>