[Approval needed] Re: [Mono-devel-list] Patch for Char. Pleasetest if it breaks your assembly!

[Miguel de Icaza]

Hello!

> > The spec says the current culture should be used, so this should be
> > committed.
> 
> Thats the reason why this needs to be applied.
> 
> However if we have code like:
> char CaseInsensitiveRegex = 'R';
> if (Char.ToLower(CaseInsensitiveRegex) == 'r')
> 
> Then this will fail in turkish locale after the patch (at least I think the
> R was one of those problematic chars) because the author probably wanted to
> call:
> if (Char.ToLower(CaseInsensitiveRegex, CultureInfo.InvariantCulture) == 'r')
> 
> And as I sayed: I found lots of code like this in corlib so I thougth it may
> be likely that such bugs (depending on the Char.ToLower bug) may also exist
> in other assemblies.

We got consensus, please apply the patch, and we should audit the code for this usage.