[Mono-devel-list] [PATCH] isinst/castclass optimizations

Ben Maurer bmaurer at users.sourceforge.net
Sat Mar 13 15:47:05 EST 2004


On Sat, 2004-03-13 at 14:08, Paolo Molaro wrote:
> > This patch simply special cases sealed types, such as blah is string.
> 
> What are the results of running the corlib test suite, the test suite in
> mono/tests and the regression tests in mini/ before and after the patch?
No additional failures.

> Also: when a change can be cleanly done without moving code around, it's
> better done that way: we are not in a contest to produce the larger
> diffs:-)
New version attached.

> There is another issue, too: the check can be done in a faster way
> so why optimize it only a bit? While we are at it we should go the full
> way. I'll let you think about the better way to optimize it (it's
> simple, really) to not spoil you the excitement of finding it
> (but, of course, you can ask and I'll tell you).

Ok, I think I give up here :-). What is your idea?

-- Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mini-typecheck-sealed.patch
Type: text/x-patch
Size: 1802 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040313/3cb8ffa3/attachment.bin 


More information about the Mono-devel-list mailing list