[Mono-devel-list] Patch for DbDataAdapter.Fill

[Juraj Skripsky]

Hello,

I refactored the DbDataAdapter.Fill methods:

- new private method FillTable does most of the work now
- mapping (datareader -> table) is stored in int[] instead of hashtable
- creation of tableArray[] is moved outside of loop (its contents are
copied by LoadRowData) => big memory savings
- bug fixed: mapping was ignored in Fill(DataTable, IDataReader)
- bug fixed: FillErrorEventArgs was initialized with data from unmapped
array
- will make implementation of the new NET_1_2 Fill methods a lot
easier...

Could someone please review the patch and test it?
Thanks!

Especially the Fill(DataSet, string, IDataReader, int, int) method
called with block SQL-statements (i.e. multiple resultsets) needs some
more testing.

- Juraj

---
Juraj Skripsky <juraj at hotfeet.ch>
HotFeet - developing the web
Technopark Zurich
Switzerland
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DbDataAdapter.diff
Type: text/x-patch
Size: 8141 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040311/ed4fe8d7/attachment.bin