[Mono-devel-list] Re: [PATCH] Various DateTime fixes and tests

[Steven Brown]

Atsushi Eno wrote:

> Hello,
> 
>>> What's the status of the DateTime patch and the regression tests?  
>>> They don't seem to be in the CVS yet; just checking to be sure they 
>>> don't slip through the cracks.
>>
>>
>> Oh, sorry. I thought the patch was already in.
>>
>> Ok, I manually applied your fixes to the current DateTime.cs as the 
>> patch attacheed. However, FromOADate test (recently Sebastien added
>> it) shows that this patch is incomplete. Well, that might be my
>> manual patchy wrong, but can you try make run-test in corlib and
>> check if it does not happen to your box?
>>
>> 9) MonoTests.System.DateTimeTest.FromOADate : Ticks-Min
>>         expected:<31242239136000000>
>>          but was:<31242239135999958>
>>
> 
> Now I committed your fixes, since those fixes are more important
> than OADate. It is nice if it would be fixed, but little important.
> 
> Thanks for the cool fixes :-)
> 
> Atsushi Eno

Could you commit the regression tests patch in that mail as well?  They 
cover a lot of the fixed cases.

One problem is the NoColonTimeZone test (for timezones like "-0700" 
rather than "-07:00") is failing.  It works with my patch on beta2, and 
the patch as committed looked ok (skimmed it at least), so there must be 
something that's changed recently around that code breaking it, now. 
Will look into it later this week if I can.