[Mono-devel-list] [PATCH] changing the implementation of HttpRequest.ServerVariables

[Torstensson, Patrik]

Hey,
 
Gonzalo needs to approve this also, I would also like to add that the
direct lookup value is cached into the dictionary and that you check if
the value is already in the dict (both for get and for get-all).
 
This is different from the behavior of MS but why not, if it will give
us better performance. I would like to see some performance tests
commited together with this patch.
 
-- Patrik
 

Patrik Torstensson

   Senior Solution Specialist - Distributed Solutions CER

Intel(r) Solution Services 

   Telephone: +46 (0)8 594 631 25

   Mobile: +46 (0)8 703 66 4620

   E-mail: patrik.torstensson at intel.com
<mailto:Patrik.Torstensson at intel.com> 

   URL: http://www.intel.com/go/intelsolutionservices
<http://www.intel.com/go/intelsolutionservices> 

 

 

 


  _____  

	From: mono-devel-list-admin at lists.ximian.com
[mailto:mono-devel-list-admin at lists.ximian.com] On Behalf Of Alon Gazit
	Sent: den 7 juni 2004 17:36
	To: mono-devel-list at lists.ximian.com
	Subject: [Mono-devel-list] [PATCH] changing the implementation
of HttpRequest.ServerVariables
	
	
	Hello,
	 
	In Order to improve performance , I have change Server Variables
implementation.
	 
	I performed the following change in HttpRequest:

	*	 Added 2 new properties : Context and WorkerRequest. 
	*	The method ParseServerVariables creates a new
ServerVariablesCollection instance instead of creating new
NameValueCollection that contains all the 
		server variables.

	ServerVariableCollection is a new class that derive from
NameValueCollection.
	While trying to get the value associated with a specified key,
the new class performs the following steps:

	*	Check if the collection was loaded in the past (meaning
that all the variables were added). if the answer is yes , 
		then return the value from the collection.  
	*	if the answer was no ,check if for this key the method
can be called directly. if the answer is yes return the method value. 
	*	it answer was no, add all the server variables to the
collection and return the key's value from the collection.

	Thanks,
	 
	Alon
	 
	  

	

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040607/9c6890ee/attachment.html