[Mono-devel-list] [PATCH] Corcompare improvements

[Gert Driesen]

----- Original Message -----
From: "Gonzalo Paniagua Javier" <gonzalo at ximian.com>
To: "Mono Development" <mono-devel-list at lists.ximian.com>
Sent: Thursday, June 03, 2004 4:15 AM
Subject: Re: [Mono-devel-list] [PATCH] Corcompare improvements


> El mié, 02-06-2004 a las 22:01, Gert Driesen escribió:
> > Hi Gonzalo,
> >
> > I've attached a few improvement/fixes to the mono-api-diff and
> > mono-api-info.
> >
> > mono-api-info will now also output protected members (as these are
> > ofcourse also part of the public API), causing them to be compared by
> > mono-api-diff too.
> >
> > mono-api-diff will now correctly considers missing attributes as a
> > mismatch, in the previous version these were also considered a
> > mismatch but only output if there were other mismatches.
> >
> > Can you review this patch, and tell me whether its ok to commit it ?
>
> It's ok, but, please, format it according to the rules in
> mcs/class/README (Coding considerations and style) before commiting.

In my case you meant to avoid extra linefeeds in control blocks (eg. if's) ?
I corrected that, but please let me know what else isn't correct, if there
is anything ...

There are no clear guideliness on what to do with try/catch/finally blocks,
so I used tris construct :

try {
    ....
} catch {
    ....
} finally {
    ....
}

Gert