[Mono-devel-list] [PATCH] API compatibility fixes for System.Data

[S Umadevi]

Gert
  I also tend to agree with Eno.. 
We currently dont have classes that are not "public" and or  have
attributes that are "msinternal".
I will apply the patch (excluding  the DataTableTypeConverter) till we
reach a decision on these attributes.

Hope this is fine with you..

regards
Uma

>>> Atsushi Eno <atsushi at ximian.com> 6/1/2004 3:34:57 PM >>>

The DataTableTypeConverter looks not publicly exposed, isn't it?

(Assuming my guess above is correct) am wondering why we should
copy "MS internal" attributes. There are many MS internal classes we
don't have. If the "fixed" corcompare tools require "internally
applied" attributes, then it looks wrong IMHO.

Well, its slipping to off-topic from System.Data. I leave the
solution to Uma. I don't think this patch breaks anything.

Atsushi Eno


Gert Driesen wrote:

> ----- Original Message -----
> From: "Atsushi Eno" <atsushi at ximian.com>
> To: "Gert Driesen" <gert.driesen at pandora.be>
> Cc: <sumadevi at novell.com>; <mono-devel-list at lists.ximian.com>
> Sent: Tuesday, June 01, 2004 9:05 AM
> Subject: Re: [Mono-devel-list] [PATCH] API compatibility fixes for
> System.Data
> 
> 
> 
>>Hello Gert,
>>
>>
>>>I've attached a patch that fixes all API mismatches between the Mono
and
> 
> MS System.Data assembly.  This one fixes more issues (only discovered
after
> fixing a minor issue in the mono-api-diff tool) than the patch I
posted
> before.
> 
>>>Can you review and commit this patch (or allow me to do so) ?
>>
>>One thing:
>>
>>
>>>+namespace System.Data
>>>+{
>>>+ internal class DataTableTypeConverter : ReferenceConverter
>>
>>I don't think we have to add MS's "internal" class to our libs.
> 
> 
> Its used as a TypeConverter for DataTable, so I think it should be
added, no
> ?
> 
> Gert
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com 
> http://lists.ximian.com/mailman/listinfo/mono-devel-list 
>