[Mono-devel-list] [PATCH] API compatibility fixes for System.Data

[Gert Driesen]

----- Original Message -----
From: "Atsushi Eno" <atsushi at ximian.com>
To: "Gert Driesen" <gert.driesen at pandora.be>
Cc: <sumadevi at novell.com>; <mono-devel-list at lists.ximian.com>
Sent: Tuesday, June 01, 2004 12:04 PM
Subject: Re: [Mono-devel-list] [PATCH] API compatibility fixes for
System.Data


>
> The DataTableTypeConverter looks not publicly exposed, isn't it?

Its exposed as typeconverter for the DataView.Table property, which is part
of the public API.  So not applying this attribute does break compatbility
with .NET, although no one will lose sleep over this specific issue I'm sure
:-)

>
> (Assuming my guess above is correct) am wondering why we should
> copy "MS internal" attributes. There are many MS internal classes we
> don't have. If the "fixed" corcompare tools require "internally
> applied" attributes, then it looks wrong IMHO.

No, the minor fix I applied to mono-api-diff has nothing to do with
"internally applied" attributes.  The previous version would report the same
mismatches in the XML output, but these would not be shown in the HTML
format unless there were other issues with the member (which was just a
minor bug).

In my opinion, there's no such thing as an "internally applied" attribute
.... every attribute that affects the behaviour of a class should be
applied, whether it effects runtime, compile-time or design time behaviour
...

> Well, its slipping to off-topic from System.Data. I leave the
> solution to Uma. I don't think this patch breaks anything.

Sure, no problem

Gert