[Mono-devel-list] PATCH : Some generics IComparable implementations
Paolo Molaro
lupus at ximian.com
Mon Jul 26 13:39:08 EDT 2004
On 07/20/04 Martin Baulig wrote:
> On Sun, 2004-07-18 at 19:29 -0400, Ewen Cheslack-Postava wrote:
> > I decided to try doing some work on generic classes and to start out I
> > implemented some of the missing IComparable<T>'s in the corlib.
> > Specifically, I implemented the interface for Boolean, DateTime,
> > Double, Single, TimeSpan, and Version. The diff is attached, I would
> > appreciate it if you could review it.
>
> Hello,
>
> your patch looks good, but unfortunately I already implemented this
> myself last week. There was a bug report open in bugzilla for a very
The last iteration of Ewen's patch has the
#if NET_2_0
, IComparable<Int32>
#endif
change instead of the uglier:
#if NET_2_0
IComparable, IComparable<Int32>
#else
IComparable
#endif
So we'd still like a patch that cleans up the code.
lupus
--
-----------------------------------------------------------------
lupus at debian.org debian/rules
lupus at ximian.com Monkeys do it better
More information about the Mono-devel-list
mailing list