[Mono-devel-list] Char.IsXXX() patch: from InternalCall to managed

Atsushi Eno atsushi at ximian.com
Wed Feb 18 09:25:05 EST 2004


> For IsWhitespace, I would rather see all the switch elements enumerated
> out. This is going to be faster than calling the other method, even if
> it will get inlined (as I understand it, that is the design of the
> Switch statement).

Yeah. I noticed that and fixed in the second patch ;-)

> Also, rather than the magic characters, can you please use constants and
> a quick comment describing what they are:


> you should be able to do:
> return c >= '\u2000' && c <= '\u200b';

Okay, it would be better. Thanks!

Atsushi Eno

More information about the Mono-devel-list mailing list