[Mono-devel-list] Re: [Mono-patches] libgdiplus/src brush.h,NONE,1.1 solidbrush.h,NONE,1.1 ChangeLog,1.5,1.6 gdip.h,1.4,1.5 brush.c,1.2,1.3 solidbrush.c,1.2,1.3 pen.c,1.1.1.1,1.2 stringformat.c,1.1,1.2

[Ravindra]

Hey Duncan,
Thanks for your comments. I have elaborated more on my changes in the
changelog, for the rest of the comments, please read below.

Regards,
Ravindra

On Sat, 2004-02-14 at 03:43, Duncan Mak wrote:
> It doesn't seem right to me that we're defining Graphics here within
> brush.h. Is it possible that we make a graphics.h and include that
> instead?
I have moved GpGraphics and GpStatus back to gdip.h.

> If you include this later in the file, I think you can avoid moving the
> code around. By keeping all the general enums and structures before
> other header files, we can ensure that the name lookup will happen
> correctly.
Yes, now I have done that.

> > @@ -66,30 +68,6 @@
> > -typedef enum {
> > -    Ok = 0,
> > -    GenericError = 1,
> > -    InvalidParameter = 2,
> > -    OutOfMemory = 3,
> > -    ObjectBusy = 4,
> > -    InsufficientBuffer = 5,
> > -    NotImplemented = 6,
> > -    Win32Error = 7,
> > -    WrongState = 8,
> > -    Aborted = 9,
> > -    FileNotFound = 10,
> > -    ValueOverflow = 11,
> > -    AccessDenied = 12,
> > -    UnknownImageFormat = 13,
> > -    FontFamilyNotFound = 14,
> > -    FontStyleNotFound = 15,
> > -    NotTrueTypeFont = 16,
> > -    UnsupportedGdiplusVersion = 17,
> > -    GdiplusNotInitialized = 18,
> > -    PropertyNotFound = 19,
> > -    PropertyNotSupported = 20
> > -} GpStatus;
> 
> Why did you move this to brush.h? The GpStatus enum is the primary
> return type used by all the functions in GDI+, I don't think it is
> specific to Brush at all. Shouldn't it stay within gdip.h?
That was my mistake. I did it just to make gcc silent.

> > -typedef struct {
> > +typedef struct _Graphics {
> >  	cairo_t         *ct;
> >  	cairo_matrix_t  *copy_of_ctm;
> >  	void            *hdc;
> >  	int             hdc_busy_count;
> >  	void            *image;
> >  	int             type; 
> > -} GpGraphics;
> > +} Graphics;
> 
> Why did you have to rename this?
I renamed this because I had another typedef for the same. This is reverted now.
I have incorporated all of your comments now.