[Mono-devel-list] (AMD64) Compiler Warnings (2)

[Martin Baulig]

On Tue, 2004-12-07 at 20:54 +0100, Willibald Krenn wrote:
> > 
> > - the FIXME in MonoDebugLineNumberEntry is wrong: `offset' can never be
> >   negative, so this'd be wrong.
> 
> It's not about the lower bound, it's about the upper bound: Some 
> functions will return -1 as indication of failure or give back the 
> offset (AFAIK) - but as signed int.

Some functions may - the symbol file will never have a negative value in
that field.  I may make a change to a smaller unsigned value in future -
and then we need all the bits.

> >   I'll commit the member name rename tomorrow (we're preparing a release
> >   right now, so I'd rather not touch the repository right now), so this
> >   should be fine.
> 
> Cool, but I guess it's not that pressing...
> 
> 
> > - I like the mono_debugger_event_handler() change, I had an open bug
> >   report about that.  I think I'll commit this tomorrow and also fix
> >   the code in the debugger which is using it
> >[..]
> >Btw. would it work by using a guint64 on all architectures ?  This'd
> >also make it a little bit easier for me in the debugger.
> 
> IMO yes..

Ok, then let's use a guint64 there.  I'll fix that in the debugger.

Martin