[Mono-devel-list] (AMD64) Compiler Warnings (2)

[Willibald Krenn]

Hi!

>> Re: the patch, first off, if you are going to have whitespace changes,
>> you should use "diff -w", so that people reviewing the diff don't have
>> to wade through irrelevant changes.
> 
> 
> Well, I just did a 'svn diff'... Will include -w in future.

Did it with -w -B -d -u this time - if you prefer other options just let 
me know!

Unfortunately svn did changes to some $Id entries while diffing, so the 
files are added to the diff although I did not change them.. Dunno what 
to do about that.

>> As for the actual changes, glib already provides macros for this which
>> already DTRT in 32-bit and 64-bit environments, GINT_TO_POINTER,
>> GUINT_TO_POINTER, GPOINTER_TO_INT, and GPOINTER_TO_UINT.

Changed all new casts to use G* macros. Note that I tried to get 
G[U]INT_TO_POINTER correct in every case, but some errors could've 
slipped my eyes.

In any case, the make (after a clean in mono module) does complete..

Thanks,
  Willi
P.S.: The intps.h header is still necessary (some places need [u]intptr 
plus lots of places need the printf-constants)  and has not changed 
since last time I sent it.
If you want intps.h to be renamed, no problem. (I don't like the name 
myself..)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clean64_0312_rc2_mono.diff.gz
Type: application/x-gzip
Size: 8869 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20041203/08e80557/attachment.gz