[Mono-devel-list] Patch for full-featured mcs /doc support

Ian MacLean ianm at ActiveState.com
Thu Dec 2 07:55:11 EST 2004


Atsushi Eno wrote:

>Hello,
>
>Thanks for cool tests :-) So I've fixed the last two bugs and
>put the patch here again:
>http://primates.ximian.com/~atsushi/mcs-doc-patches/mcs-doc-20041202.diff
>  
>
great. My linux box is powered off at the moment - so I'll test it a bit
later.

>One thing I am wondering is that if there are any checks against
>"paramref" element used in this testcase. Do you have any ideas?
>
>  
>
well paramref is used quite frequently in the NAnt sources and it seems
to handle it ok. Is that what you meant ?

I also used ndoc to build the nant user docs from the mcs/doc generated
xml - that all looks good too.

Ian

>Atsushi Eno
>
>
>Ian MacLean wrote:
>  
>
>>>Atsushi Eno wrote:
>>>
>>>I've attached the fix. I changed nothing other than doc.cs, so I
>>>just attach it. I put the full patch here:
>>>http://primates.ximian.com/~atsushi/mcs-doc-patches/mcs-doc-20041202.diff
>>>
>>>
>>>
>>>
>>>      
>>>
>>>>maybe I should wait till you get this all committed to svn and then
>>>>start logging these in bugzilla ?
>>>>  
>>>>
>>>>        
>>>>
>>>No, let's fix all the problems before I check in the code, if any.
>>>Please tell me if you found more problems. Thanks :-)
>>>
>>>
>>>
>>>      
>>>
>>Just one more small one. It seems csc treats 4 slashes as a regular
>>comment while your patch is treating it as doc comment. So
>>
>>//// Some comment
>>using System;
>>using System.IO;
>>...
>>
>>causes :
>>
>>Class1.cs(2) warning CS1587: XML comment is placed on an invalid
>>language element which can not accept it. Csc gives the same error if
>>there are only 3 slashes - ///.
>>
>>Apart from that mcs with the doc patch now builds the nant sources which
>>use xml comments extensively - so they are a pretty good test. I'm just
>>testing with ndoc to see how it likes the xml output.
>>
>>Ian
>>
>>    
>>




More information about the Mono-devel-list mailing list