[Mono-devel-list] mcs build error on windows

[Martin Baulig]

Patch looks good.

On Sun, 2004-08-01 at 03:35 +0900, Atsushi Eno wrote:
> Hi,
> 
> The latest mcs is broken on csc build.
> 
> First, you will have to replace all '/' path separators with '\\'
> in EXTRA_SOURCES. (Maybe makefile gurus can fix it?)
> 
> The second one is in ilasm:
> 
> make[3]: Entering directory `/home/_/cvs/mcs/ilasm'
> csc.exe /lib:../class/lib/default /lib:../class/lib/default /r:PEAPI.dll
> /r:Mono.CompilerServices.SymbolWriter.dll /nologo /optimize -d:NET_1_1
> -d:ONLY_1_1 /debug+ /debug:full /target:exe /out:ilasm.exe ILParser.cs
> @../build/deps/ilasm.exe.response
> codegen\DebuggingInfo.cs(30,23): error CS0050: Inconsistent accessibility:
>         return type
> 
> 'Mono.CompilerServices.SymbolWriter.MonoSymbolWriter.SourceMethod' is
>         less accessible than method
>         'Mono.ILASM.SymbolWriter.BeginMethod(Mono.ILASM.MethodDef,
>         Mono.ILASM.Location)'
> c:\cygwin\home\_\cvs\mcs\class\lib\default\Mono.CompilerServices.SymbolWriter.dll:
> (Location of symbol related to previous error)
> 
> Attached patch fixes this problem. Ok to commit?
> 
> Atsushi Eno
> 
> plain text document attachment (buildfix.diff)
> ? buildfix.diff
> Index: DebuggingInfo.cs
> ===================================================================
> RCS file: /cvs/public/mcs/ilasm/codegen/DebuggingInfo.cs,v
> retrieving revision 1.2
> diff -u -r1.2 DebuggingInfo.cs
> --- DebuggingInfo.cs	30 Jul 2004 17:01:05 -0000	1.2
> +++ DebuggingInfo.cs	31 Jul 2004 17:34:40 -0000
> @@ -18,7 +18,7 @@
>  	public class SymbolWriter : MonoSymbolWriter
>  	{
>  		ArrayList sources;
> -		SourceMethod current_method;
> +		Mono.ILASM.SourceMethod current_method;
>  		SourceFile current_source;
>  
>  		public SymbolWriter (string filename)
> @@ -27,9 +27,9 @@
>  			sources = new ArrayList ();
>  		}
>  
> -		public SourceMethod BeginMethod (MethodDef method, Location location)
> +		public Mono.ILASM.SourceMethod BeginMethod (MethodDef method, Location location)
>  		{
> -			current_method = new SourceMethod (method, location);
> +			current_method = new Mono.ILASM.SourceMethod (method, location);
>  			current_source.AddMethod (current_method);
>  			return current_method;
>  		}