[Mono-devel-list] [Patch] typemanager should use InvariantCulture

Robert Shade rshade at dvsconsulting.com
Fri Apr 30 17:08:41 EDT 2004

Ok.  Attached are updated patches that address the only other use of 
ToUpper or ToLower in mcs and gmcs (cs-parser.jay).  Please commit for 
me, please.  The OSX build is broken without it.  (there's currently a 
problem with the icu in fink that is triggered by this


-------------- next part --------------
A non-text attachment was scrubbed...
Name: gmcstypemanager.diff
Type: application/octet-stream
Size: 2154 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040430/2a1c5d2b/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mcstypemanager.diff
Type: application/octet-stream
Size: 2175 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040430/2a1c5d2b/attachment-0001.obj 
-------------- next part --------------

On Apr 30, 2004, at 2:09 PM, Andreas Nahr wrote:

> I already wrote on the list that we need to check ALL occurences of
> String.ToXXX() and Char.ToXXX().
> I checked through corelib and corrected there.
> Just for the stats: I found about 30 occurences of them and only one 
> was
> correct.
> I guess it will not look much better in other assemblies (I've seen 
> Atsushi
> did some changes for System.XML)
> Andreas
>> While compiling gmcs on OS X, i hit bug 52065.  While investigating I
>> found the call to String.ToLower() in TypeManager.CSharpNameMatch()
>> should probably be using the InvariantCulture.  Attached are patches
>> for both mcs and gmcs.
>> Robert Shade
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list

More information about the Mono-devel-list mailing list