[Mono-devel-list] Patch for ToUpper/ToLower

Robert Shade rshade at dvsconsulting.com
Fri Apr 23 19:33:46 EDT 2004

My previous patch found a small bug in 
System.Collections.CaseInsensitiveHashCodeProvider.  The default 
constructor was not setting its culture to the Thread.CurrentCulture.  
This will need applied if the previous patch is.



On Apr 23, 2004, at 6:07 PM, Robert Shade wrote:

> According to the documentation, String.ToUpper/ToLower and 
> Char.ToUpper/ToLower should throw an ArgumentNullException if the 
> CultureInfo argument is null.  Attached is a patch to do just that.  
> My only question is if it would have been better to use 
> MONO_CHECK_ARG_NULL from object.h.  I wasn't sure if that would abort 
> the current function or not.  If if MONO_CHECK_ARG_NULL would be 
> preferred, I can resubmit.  Either way I would need someone to commit 
> this for me as I don't have CVS access.
> Thanks.
> Rob
> <cultureinfonull.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CaseInsensitiveHashCodeProviderCulture.diff
Type: application/octet-stream
Size: 1432 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040423/58588263/attachment.obj 
-------------- next part --------------

More information about the Mono-devel-list mailing list