[Mono-devel-list] patch for mcs /doc (phase 3)

Atsushi Eno atsushi at ximian.com
Wed Apr 21 03:17:41 EDT 2004

Hello, (I failed to send it to the list)

After receiving some comments from Miguel and Ben (thanks, and sorry
for being late), I created the third patch for mcs /doc support.
The changes are:

	- Moved some documentation properties from Driver to
	  RootContext (and changing them as fields) *1
	- Added FixupDocument() method to DeclSpace, MemberBase and
	  RootContext that processes (and releases) documentation
	  memory in the earlier compilation stage than the previous
	  patch (from next to Emit() to next to ResolveTree()) *2
	- tiny bugfix: When comment was /**/, cs-tokenizer borked.

Some comments:

*1 Had I better also move xml filename field? I kept it to driver
     similar to binary output filename.

*2 I might overuse TypeContainer.ResolveType() in the fixup methods,
     but I could not find any good way to acquire full typename.

*3 BTW, I don't think it should be counted for Mono 1.0 feature. This
     support is very rough and it rarely reports improper comments.
     (I really don't think /doc support is important)

I also put the source archive for mcs/mcs directory and profile
results here:
(Patches are: before patched / without --document / with --document)

Atsushi Eno

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mcs-doc-20040421.diff
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040421/78623f6a/attachment.pl 

More information about the Mono-devel-list mailing list