[Mono-devel-list] [Patch] incorrect usage of ves_icall_System_Threading_Thread_Abort (by mono/metadata/threads.c)

[David Waite]

The threads.c functions remove_and_abort_threads and 
abort_appdomain_thread both pass in a second argument to the abort 
icall. In the case of remove_and_abort_threads, the wrong type of 
struct * is being passed in; abort_appdomain_thread is casting a domain 
object to a MonoObject* (which is equally wrong).

The state appears to be saved within the thread->abort_state variable, 
which is made available to the Thread class, and (by documentation) is 
supposed to be included in a ThreadAbortException.

The attached patch simply passes in NULL rather than the existing 
values, as I could not determine what would be appropriate to pass in.

-David Waite
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thread_abort.patch
Type: application/octet-stream
Size: 981 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20040420/0c2f228a/attachment.obj