[Mono-devel-list] [Patch] mono_metadata_encode_value slightly off

Paolo Molaro lupus at ximian.com
Mon Apr 19 13:58:18 EDT 2004


On 04/17/04 David Waite wrote:
> The encode function was off for blocks which were exactly 16k. This 
> patch uses the same sign for both comparisons, and uses hex values for 
> easier comprehension.

On 04/17/04 David Waite wrote:
> The load_metadata_ptrs leaves the pointer incremented past the stream 
> header into the block. in the case where the type is not known, the 
> increment had a high probability of failing - strlen was used to find 
> the length of the c string name field, but the offset was at the offset 
> and length information before the name field started.

For the record, both patches are approved.

lupus

-- 
-----------------------------------------------------------------
lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better



More information about the Mono-devel-list mailing list