[Mono-devel-list] System.Data - Patch for ForeignKeyConstraint ctor

[Gonzalo Paniagua Javier]

El sáb, 03-04-2004 a las 09:33, Deepak P N escribió:
> Hi,
> 	I have implemented the patch for :
> 	
> 	ForeignKeyConstraint (string, string, string[], string[], AcceptRejectRule, Rule, Rule);
> 		
> 	[ Here's the approach >
> 		ParentTable - Since only name is given (not the DataTable object), we cannot associate any DataTable or DataSet right now.  So, only possible way is to do it when AddRange() is called.  The ParentTable is searched in the DataSet to which the calling DataTable belongs.
> 		And make the calling DataTable as ChildTable.
> 
> 		1). ForeignKeyConstraint.cs - 
> 			ForeignKeyConstraint(string, string, string[], string[], acceptRejectRule, Rule, Rule);
> 			PostAddRange() - Validates the named columns in both parent and child tables.  And sets the child and parent column values to appropriate values.
> 	
> 		2). ConstraintCollection.cs  
> 			AddRange()
> 	<   ]
> 
> 	Can anyone please tell me if it is fine!

The patch is ok, but one thing. Why do you remove those attributes in
DataTable?

Also, please, check http://www.go-mono.com/ccvs.html (making patches),
which contains information on how to send proper patches. Don't forget
to modify ChangeLog saying what your patch does.

Thanks!

-Gonzalo