[Mono-devel-list] [PATCH] bugs in System.Data.DataRelationCollection

Eran Domb erand at mainsoft.com
Mon Sep 29 08:16:33 EDT 2003


Hello,
 I found some bugs in System.Data.DataRelationCollection.
1. When adding a relation to the collection the name calculation is
wrong.
2. DataSetRelationCollection.AddCore(DataRelation relation) does not
check that a UniqueConstraint is already exists. It loops over the
Relations instead of the Constrains.
3. Add(DataRelation relation) adds the relation to the List and also
DataSetRelationCollection.AddCore(DataRelation relation) adds the
relation to the List
so that the relation added 2 times to the list.
 
Attached are a TestCase and a patch.
 
Thanks
Eran. 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/a539834b/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DataRelationCollection.cs.diff
Type: application/octet-stream
Size: 3081 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/a539834b/attachment.obj 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: DataRelationCollectionTest.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/a539834b/attachment.pl 


More information about the Mono-devel-list mailing list