[Mono-devel-list] [PATCH] bugs in System.Data.DataRow

[Eran Domb]

Hello,
I found some bugs in System.Data.DataRow.
1. In AcceptChanges() there is no special case for RowState.Detached.
2. In CanselEdit() the editing flag is not turned to false.
3. IsNull(.) - there is no check that the value is DBNull.
4. CopyValuesToRow(DataRow row) - there is no check that the row has a
value of a specific DataRowVersion.
 
Attached are TestCase and a patch.
 
Thanks
Eran.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/9715c9b1/attachment.html 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: DataRowTest.cs
Url: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/9715c9b1/attachment.pl 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DataRow.cs.diff
Type: application/octet-stream
Size: 2917 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030929/9715c9b1/attachment.obj