[Mono-devel-list] Re: [Mono-patches] mcs/class/corlib ChangeLog,1.102,1.103 corlib_test.dll.sources,1.6,1.7

Gonzalo Paniagua Javier gonzalo at ximian.com
Sat Sep 27 06:56:49 EDT 2003


El sáb, 27-09-2003 a las 08:18, yoros at wanadoo.es escribió:
> On Sat, Sep 27, 2003 at 01:27:25AM +0200, Gonzalo Paniagua Javier wrote:
> > El vie, 26-09-2003 a las 18:57, Pedro Martinez  escribió:
> > > Update of /cvs/public/mcs/class/corlib
> > > In directory mono-cvs.ximian.com:/tmp/cvs-serv620
> > > 
> > > Modified Files:
> > > 	ChangeLog corlib_test.dll.sources 
> > > Log Message:
> > > 2003-09-26  Pedro Martínez Julá  <yoros at wanadoo.es>
> > > 
> > >     * corlib_test.dll.sources: Remove tests that generate compile
> > >     errors. The tests are still there but its name is rmoved here.
> > > 
> > 
> > I suggest reverting this patch. We don't want to hide compilation errors
> > away, but fix them.
> > 
> 
> They are not "errors". Mono.Math can't be accessed out of corlib (it's
> internal), the other tests I removed needs System.Runtime.Remoting.dll
> assembly to be referred in compilation time. I think that these tests
> must be in System.Runtime.Remoting assembly tests.
> 
> I can insert the references for the System.Runtime.Remoting tests and
> add a /r:System.Runtime.Remoting in the Makefile, May I do it?

It's ok to leave those test where they are as long as they test corlib.
Referencing other assemblies is also fine.

-Gonzalo





More information about the Mono-devel-list mailing list