[Mono-devel-list] [PATCH] implementation of System.Data.DataSet.Merge(...)

[Duncan Mak]

Hello Eran,

On Mon, 2003-09-22 at 15:04, eran wrote:
> 
> I implemented System.Data.DataSet.Merge(...) and
> System.Data.DataSet.GetChanges(...) and
> System.Data.DataSet.HasChanges(...).
> 
> It also involves changes in System.Data.DataRow.
> 

This patch hasn't been applied to CVS yet because it does not compile
properly:

System.Data/MergeManager.cs(122) error CS0103: The name `Res.GetString'
could not be found in `System.Data.MergeManager'
System.Data/MergeManager.cs(162) error CS0103: The name `Res.GetString'
could not be found in `System.Data.MergeManager'

The variable 'Res' doesn't exist in the file, but we do have a Locale
class, and you can use 'Locale.GetText' to a similar effect.

In addition, I have applied 7 patches you sent to the list on Monday.
They are:

1) missing validation in System.Data.DataRowCollection.Add(DataRow row)
2) bug in System.Data.UniqueConstraint.AssertConstraint(DataRow row)
3) bug in System.Data.Common.DbDataAdapter.Fill(DataSet dataset,
DataTable srcTable, IDataReader dataReader, int startRecord, int
maxRecords)
4) bug in System.Data.DataTableCollection.Add(DataTable table).
5) implementation of System.Data.DataTableCollection.CanRemove(DataTable
table)
6) bug in System.Data.DataRelation.Add(...)
7) implementation of System.Data.DataColumn.Unique

As for all the attached test cases, I really don't have time to look
into them and rewrite them as NUnit TestCases now. In the future, it
would be much more preferable to submit NUnit test cases than simple
discrete programs as a test case, as that helps us improve our existing
testsuite.

Thanks for the contribution!

Duncan.