[Mono-devel-list] [PATCH] bitwise problem in System.Collections.Specialized.BitVector32.this[int mask] property

Duncan Mak duncan at ximian.com
Thu Sep 4 15:34:06 EDT 2003


Hello Alon,

On Tue, 2003-09-02 at 09:31, Alon Gazit wrote:
> 
> The property System.Collections.Specialized.BitVector32.this[int
> mask] currently doesn't return the correct value when the data in the
> BitVector32 instance is negative. 
> 

Thank you so much the patches. I have just integrated 5 patches that
were sent to the list. They are:

1) [PATCH] null argument testing in
System.Collections.Specialized.ListDictionary.Remove()

2) [PATCH] parameters validation testing in
System.Collections.Specialized.ListDictionary.CopyTo()

3) [PATCH] offset validation testing in
System.Collections.Specialized.BitVector32.CreateSection()

4) [PATCH] bitwise problem in
System.Collections.Specialized.BitVector32.this[BitVector32.Section
section] property

5) [PATCH] bitwise problem in
System.Collections.Specialized.BitVector32.this[int mask] property

The Test.cs files that were attached with each of the patches are also
integrated into our NUnit test suite.

In the future, it would be really great if you could send NUnit test
cases instead of standalone programs that illustrates the bug, as this
vastly simplifies the patch integration process. To see a sample NUnit
test case, check the new ListDictionaryTest.cs file that I just
committed.

Either way though, again thank you so much for your patches. I await for
more patches from you ;-)

Happy hacking,
Duncan.



More information about the Mono-devel-list mailing list