[Mono-devel-list] [PATCH] fix problems in System.Data.Common.DbDataAdapter.cs

[Eran Domb]

Hello,
I found some bugs in DbDataAdapter.cs
1. Fill(DataTable dataTable, IDataReader dataReader) - add only the
mapped column to the dataTable (not all columns of dataReader).
            Also closing the dataReader if an exception is thrown.
2. Fill(DataSet dataset, string srcTable, IDataReader dataReader, int
startRecord, int maxRecord) - the same as above.
3. SetupSchema(SchemaType schemaType, string sourceTable, DataTable
table) - in now return string (the table name). 
4. GetFillParameters() - fix a bug.
5. BuildSchema(IDataReader dataReader, DataTable table, SchemaType
schemaType) - it now return Hashtable. Add columns to the table only if
there is a mapping. Build an Hashtable that maps the columns from the
table to the column from the reader.
6. Update(DataRow[] dataRows, TableMapping tableMapping) - first open
the connection if needed. Catch an exception of the ExecuteQuery.
 
Attached is a diff file. If no-one objects I will commit.
 
Thanks,
Eran Domb.
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20031012/c366a54c/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DbDataAdapter.cs.diff
Type: application/octet-stream
Size: 13152 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20031012/c366a54c/attachment.obj