[Mono-devel-list] [PATCH] fix problems in System.Data.DataRow.cs

Eran Domb erand at mainsoft.com
Sun Oct 12 09:13:46 EDT 2003


Hello,
I found some problems in DataRow:
1. In the constructor we initiate the current array, but we should
initiate only the proposed array for new rows.
2. Implement HasErrors().
3. Delete() - added checking for child rows of the deleted row.
4. EndEdit() - added checking for child row and firing events.
5. GetColumnError(int columnIndex) - added a check that the method will
not return null, as in ADO.NET(an empty string is returned).
6. GetColumnsInError() - added a check for null values in column error.
And sending to ToArray the DataColumn Type as a parameter (The cast form
ToArray() to DataColumn[] throw an exception).
7. HasVersion(DataRowVersion ) - added special treatment for special
RowState.
8. CollectionChanged(.) - more check to avoid NullReferenceException. 
 
Attached is a diff file. If no-one objects I will commit.
 
Thanks,
Eran Domb.
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20031012/15a6f2a6/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DataRow.cs.diff
Type: application/octet-stream
Size: 510 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20031012/15a6f2a6/attachment.obj 


More information about the Mono-devel-list mailing list