[Mono-devel-list] Remoting patches and typo fix

[Lluis Sanchez]

Hi Jerome!

>     Here are two patches for remoting. The first (20030315) has already
been posted,
> I'm reposting it as i don't know if it has not been commited because of a
bug, or because
>  it has been forgeted :) It adds some missing properties to the TcpChannel
like bindTo or priority.

It is ok to me except for this line in TcpChannel.cs:

+ if(port != 0)
+ _serverChannel = new TcpServerChannel(properties, serverSink);

If port is 0, then a TcpServerChannel must be created, using any free port,
so this condition is not needed.

>     The second one is a fix for the remoting in the current CVS. The
CrossAppDomainChannel
>  has been added to ChannelServices as a standard channel and took the
priority over other
>  channels like TcpChannel. This was leading to a SyncProcessMessage
processing messages
>  on the client side as if they were on the server side.
> I don't know if it is best the way to fix this... but all the tests
concerning the remoting part
>  concerning local cross context operations seem to run fine. The remote
ones too.

Do you have a test case for this? I think that the problem is in
CrossAppDomainChannelData. It should contain the process id. When
CrossAppDomainChannel.CreateMessageSink tries to create a message sink from
the channel data it should check both the process id and domain id, because
domain ids are local to the process.

>     The last patch is a small typo fix for the class.h file, a "klass"
instead of "class"... it's messing up
>  the C++ compiler :)

What's the problem? "class" is not a keyword in C.

> Jerome.