[Mono-devel-list] Re: cs-parser.jay.diff and test-case

Gaurav Vaish gvaish at adobe.com
Sat Mar 29 03:11:35 EST 2003


----- Original Message -----
From: "Ravi Pratap M" <ravi at ximian.com>
To: "Gaurav Vaish" <gvaish at adobe.com>
Cc: "Mono Devel List" <mono-devel-list at ximian.com>
Sent: Friday, March 28, 2003 23:52
Subject: [Mono-devel-list] Re: cs-parser.jay.diff and test-case


> Hi Gaurav,
>
> The patch looks good - you may go ahead and commit after ensuring that
> the regression tests all compile as usual. The self-compilation should
> also work fine after this patch.

    This is all working fine after applying the patch. I have not yet
committed it because of what follows...

>
> errors directory with the appropriate error number (if this is another
> error test for the a number which already exists, use suffixes of -1, -2

    Done as cs1518-2.cs. Test Passed OK.

> etc). Please make sure you document it too in the ChangeLog and the
> README file (if there is one).

    I find that the mcs cannot build library - System.
    I reverted the patch (getting in sync with the cvs) and re-checked the
library compilation - it still fails. Can you verify the broken compilation
at your end?

    Once done, I will commit the code.

>
>
> Thanks a lot for the fix !


Happy Hacking,
Gaurav
http://mastergaurav.virtualave.net/iitk
---------------------------------------






More information about the Mono-devel-list mailing list