[Mono-devel-list] System.Data.DataRow big patch

[Alan Tam]

Committed.

After thinking, there are 5 types of states, Detached, Added, Modified, Deleted
and Unchanged. One can add, delete, attach and detach a row, with modification
and without modification. So there should be at most 5*4*2 = 40 test cases.
Seems data path coverage testing is feasible.

I will try later to construct test cases consider all these cases. However, I
still have to look at how I can specify them as a NUnit test ...

Regards,
Alan

----- Original Message -----
From: "Daniel Morgan" <danmorg at sc.rr.com>
To: "Alan Tam" <Tam at siulung.com>; <mono-devel-list at lists.ximian.com>
Sent: Friday, March 21, 2003 9:03 PM
Subject: RE: [Mono-devel-list] System.Data.DataRow big patch


Hello Alan Tam,

Your patch look good.  I verified your patch against current cvs, and it works.

Can you commit your patch please?

Thanks,
Daniel

-----Original Message-----
From: mono-devel-list-admin at lists.ximian.com
[mailto:mono-devel-list-admin at lists.ximian.com]On Behalf Of Alan Tam
Sent: Friday, March 21, 2003 4:01 AM
To: mono-devel-list at lists.ximian.com
Subject: [Mono-devel-list] System.Data.DataRow big patch


Dear all,

I've looked at the DataRow code and found that the DataRowState and
DataRowVersion codes are mostly only just working. If you build by test program
and run it against both platforms you will feel unhappy that nearly all tests
failed.

I've prepared a patch, that at least passed all tests I prepared. In addition I
also fixed a little in DataRowCollection and DbDataAdapter (which depends on
the old wrong behavior).

Please review my patch and see if it breaks other things. If there is no
objection, I will commit it.

Regards,
Alan