[Mono-devel-list] formatting floating point values

Paolo Molaro lupus at ximian.com
Tue Mar 4 13:05:22 EST 2003

yoros committed a patch to cvs that implements the long-needed
code to format floating point numbers. The patch was partially reverted
by Dick because it broke nunit, so that needs to be investigated
(that is to say, we need regression tests for this code, badly).

First: when some internal call is not needed anymore it's better to
actually remove it from the sources a few days after it's unused so that
people don't unnecessarily get out of sync warnings or errors.

My other comment concerns code duplication in DoubleFormatter.cs and
SingleFormatter.cs: I don't think there is any need to have two versions
of the same code when the only difference is basically just the default
precision. Can't we simple use the DoubleFormatter.cs code with one
or two additional parameters?


lupus at debian.org                                     debian/rules
lupus at ximian.com                             Monkeys do it better

More information about the Mono-devel-list mailing list