[Mono-devel-list] Re: [Mono-list] Patch for selective logging

Miguel de Icaza miguel at ximian.com
Tue Mar 4 12:34:03 EST 2003


Hello!

> On 03/04/03 Jerome Laban wrote:
> >     This is an update for the selective logging. Thanks to gonzalo and his advices, code is now more in the "mono spirit" :)
> 
> Good starting work, my comments are below:
> 
> >   Two options are also added to command line :
> >     a.. --log-level=VALUE, for which the possible values are from 2 to 7 (mapped from the G_LOG_LEVEL_XXX enum). 2 stands for error messages only, 7 for error+critical+warning+message+info+debug. 
> >     b.. --log-mask=MASK, it is the decimal value of the mask. See mono-logger.h for more infos on possible values.
> 
> We should not expose magic numbers to the user (and I'm sure I won't be
> able to remember the values myself and I'd have to lookup them each time
> in the header file and do the math...).

I only want to add that any patch like this should also include a patch
for the man pages ;-)

Miguel



More information about the Mono-devel-list mailing list