[Mono-devel-list] Removing GetHashCode and Equal from System.AppDomain and System.OperatingSystem

[Duncan Mak]

On Thu, 2003-07-24 at 09:05, Paolo Molaro wrote:
> On 07/23/03 Duncan Mak wrote:
> > Index: System/OperatingSystem.cs
> 
> I would leave the methods in OperatingSystem, the reference compare done
> by the Object methods would be incorrect for our implementation.

Okay. It'll show up as an additional member on CorCompare, that's fine I
guess.

> > Index: System/AppDomain.cs
> >  		
> > -		public override bool Equals (object other)
> [...]
> > -		public override int GetHashCode ()
> 
> Just remove the methods here.

Okay, I removed the methods and committed that.

> > Index: System.Reflection.Emit/OpCodes.cs
> > ===================================================================
> > RCS file: /cvs/public/mcs/class/corlib/System.Reflection.Emit/OpCodes.cs,v
> > retrieving revision 1.3
> > diff -u -p -r1.3 OpCodes.cs
> > --- System.Reflection.Emit/OpCodes.cs	8 May 2002 13:21:11 -0000	1.3
> > +++ System.Reflection.Emit/OpCodes.cs	24 Jul 2003 03:40:47 -0000
> > @@ -36,7 +36,7 @@ namespace System.Reflection.Emit {
> >    		public static readonly OpCode Box;
> > -  		public static readonly OpCode Boxval;
> > +//  		public static readonly OpCode Boxval;
> 
> Did you compile after the change? You'd also need to remove the line
> where Boxval is assigned to. Though I don't know of any user of this
> opcode, the .net 1.0 framework has it (it's the same as Box). They
> have it marked with the Obsolete attribute and we probably should do the
> same.

Here's a patch that marks Boxval with the ObsoleteAttribute. Should I
commit this? Should I also remove the line where Boxval is assigned to?

thanks,

Duncan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Obsolete-Boxval.patch
Type: text/x-patch
Size: 1244 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030725/6ccda903/attachment.bin