[Mono-devel-list] handles.c patch

[Bernie Solomon]

Re: [Mono-devel-list] handles.c patchThis still fails.

As I said I wasn't sure my patch was quite right. But it is the private_list's shared_cond & shared_mutex that I am initializing (though maybe in the wrong place) not the shared ones. _wapi_handle_timedwait_signal waits on these if _POSIX_THREAD_PROCESS_SHARED is undefined and they don't seem to be initialized anywhere else.

Bernie
  ----- Original Message ----- 
  From: Dick Porter 
  To: Bernie Solomon 
  Cc: mono-devel-list at lists.ximian.com 
  Sent: Wednesday, July 23, 2003 8:39 AM
  Subject: Re: [Mono-devel-list] handles.c patch


  On Wed, 2003-07-23 at 01:29, Bernie Solomon wrote: 
  >  
  > I eventually realized that one reason things were slow for me is that 
  > the thread management thread was in a busy loop because mutexes 
  > weren't initialized so calls continually failed. 

  Strange... 

  > I am not 100% sure this is the correct fix but it addresses my test 
  > case. I am currently configuring with shared handles disabled. The fix 
  > makes everything twice as fast for me having removed a busy thread. 

  This shouldn't actually do anything, because the shared mutex code 
  should be disabled.  Please try the attached patch instead and see if 
  that has the same effect. 

  >  
  > I assume this matters on HP because initializing mutexes to zeroes 
  > isn't the right thing to do yet presumably is OK on other platforms. 

  I'll save your suggested patch for when I get the time to make the 
  shared mutex code work.  The new Linux thread libraries support 
  process-shared objects. 

  Thanks, 

  - Dick 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030723/3ed11b61/attachment.html