[Mono-devel-list] Commit incorrect

[Jerome Laban]

My mistake. It breaks the build when using the NET_1_1 define, so I
removed the second definition. It seems that there is a problem with mcs
that does not seem to handle the parameter AllowMultiple when compiling
the assembly System.dll.

Using this parameter in an other assembly is working well. Which
compiler do you use ?

-----Original Message-----
From: mono-devel-list-admin at lists.ximian.com
[mailto:mono-devel-list-admin at lists.ximian.com] On Behalf Of Andreas
Nahr
Sent: Monday, July 14, 2003 11:55 AM
To: Miguel de Icaza
Cc: mono-devel-list at lists.ximian.com
Subject: [Mono-devel-list] Commit incorrect


Hi,

is it possible to remove a commit?

The following commit is incorrect:

It removes the second Designer attribute. This is incorrect - it is not
duplicate but just a second designer specified (which is perfectly
valid) and the signature that is used in the .Net framework!

Andreas


[Mono-patches] mcs/class/System/System.ComponentModel
ChangeLog,1.74,1.75 IComponent.cs,1.6,1.7

Update of /cvs/public/mcs/class/System/System.ComponentModel
In directory mono-cvs.ximian.com:/tmp/cvs-serv19959

Modified Files:
ChangeLog IComponent.cs
Log Message:
2003-07-14 Jerome Laban <jlaban at wanadoo.fr>

        * IComponent.cs: Removed duplicate Designer attribute.



Index: ChangeLog
===================================================================
RCS file: /cvs/public/mcs/class/System/System.ComponentModel/ChangeLog,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -d -r1.74 -r1.75
--- ChangeLog 13 Jul 2003 22:06:16 -0000 1.74
+++ ChangeLog 14 Jul 2003 09:51:39 -0000 1.75
@@ -1,3 +1,7 @@
+2003-07-14 Jerome Laban <jlaban at wanadoo.fr>
+
+ * IComponent.cs: Removed duplicate Designer attribute.
+
 2003-07-13  Andreas Nahr <ClassDevelopment at A-SoftTech.com>

  * Component.cs: Implementation added

Index: IComponent.cs
===================================================================
RCS file:
/cvs/public/mcs/class/System/System.ComponentModel/IComponent.cs,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -d -r1.6 -r1.7
--- IComponent.cs 2 Jul 2003 14:51:39 -0000 1.6
+++ IComponent.cs 14 Jul 2003 09:51:39 -0000 1.7
@@ -19,12 +19,10 @@
  [ComVisible (true), TypeConverter (typeof
(System.ComponentModel.ComponentConverter))]
  #if (NET_1_0)
     [Designer ("System.Windows.Forms.Design.ComponentDocumentDesigner,
System.Design, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", typeof (IRootDesigner)),
- Designer ("System.Componentmodel.Design.ComponentDesigner,
System.Design, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", typeof (IDesigner)),
  RootDesignerSerializer
("System.ComponentModel.Design.Serialization.RootCodeDomSerializer,
System.Design, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a",
"System.ComponentModel.Design.Serialization.CodeDomSerializer,
System.Design, Version=1.0.3300.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", true)]
  #endif
  #if (NET_1_1)
     [Designer ("System.Windows.Forms.Design.ComponentDocumentDesigner,
System.Design, Version=1.0.5000.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", typeof (IRootDesigner)),
- Designer ("System.Componentmodel.Design.ComponentDesigner,
System.Design, Version=1.0.5000.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", typeof (IDesigner)),
  RootDesignerSerializer
("System.ComponentModel.Design.Serialization.RootCodeDomSerializer,
System.Design, Version=1.0.5000.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a",
"System.ComponentModel.Design.Serialization.CodeDomSerializer,
System.Design, Version=1.0.5000.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a", true)]
  #endif
  public interface IComponent : IDisposable

_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list