[Mono-devel-list] Socket.SetSocketOption multicast patch

[Jerome Laban]

Hi monoers,

    Here are two patches for Socket.SetSocketOption for the options
AddMembership and DropMembership and one for the MulticastOption class.

	Three problems here, the first is that the MulticastOption
members can be set to null through its properties and can cause an
uncatchable exception in
ves_icall_System_Net_Sockets_Socket_SetSocketOption_internal function;
Just added a check for it.

    The second one is a fix for the ipaddress_to_struct_in_addr
function, which was converting the internal network ordered value of
IPAddress with htonl. Just removed the call to htonl.

    The last one is the value checking of the two MulticastOption class
ctors. Setting either group or localAddress to null throws an exception.
(as in ms.net)

Could anyone review these patches and commit if ok ?

Jerome.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MulticastOption-20030428.diff
Type: application/octet-stream
Size: 848 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030428/e6678a06/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: setsockopt-20030428.diff
Type: application/octet-stream
Size: 2590 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20030428/e6678a06/attachment-0001.obj