[Mono-bugs] [Bug 693160] New: crash when creating gc.log where process has no W permission

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=693160

https://bugzilla.novell.com/show_bug.cgi?id=693160#c0


           Summary: crash when creating gc.log where process has no W
                    permission
    Classification: Mono
           Product: Mono: Runtime
           Version: 2.6.x
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: Critical
          Priority: P5 - None
         Component: GC
        AssignedTo: lupus at novell.com
        ReportedBy: coustet at hpc-sa.com
         QAContact: mono-bugs at lists.ximian.com
          Found By: ---
           Blocker: ---


User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.1) Gecko/20100101
Firefox/4.0.1

Crash is reported to be "Open of log file failed".
Happens only if software is installed (running in some Program File directory).
When running in a build directory, a gc.log file is created and the crash never
occurs.

Reproducible: Sometimes

Steps to Reproduce:
1. Run the app in some system dir (Program Files),
2. until the gc needs to log some information,
3. the app crash trying to create the log file.
Actual Results:  
Fatal Error popup.

Expected Results:  
No log file created, no popup. 
Could be better to define default log directory to be tmp, 
even better to allow to specify a custom log file.
But not needed to fix the bug.

Looking at the source file libgc/misc.c, seems to be easily fixable by
returning -1 instead of aborting.

-  if (GC_stdout == INVALID_HANDLE_VALUE) ABORT("Open of log file failed");

+  if (GC_stdout == INVALID_HANDLE_VALUE) return -1;

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.