[Mono-bugs] [Bug 609109] [Regression] Incoming tablular data stream (TDS) remote procedure call (RPC) protocal stream is incorrect.

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=609109

https://bugzilla.novell.com/show_bug.cgi?id=609109#c33


--- Comment #33 from scott fluto <srfcanada at hotmail.com> 2011-03-14 14:37:12 UTC ---
Given all the complex problems related to this issue I decided to track down
the patch that originated these issues and found the following patch is where
all these bugs were introduced:

https://github.com/mono/mono/commit/124c0ce55f13ca67cf8f7641a9bb3b034ac7dd5e#mcs/class/Mono.Data.Tds/Mono.Data.Tds.Protocol/TdsComm.cs


This patch just basically introduces some performance optimizations but
introduced a lot of bugs as given that most of the subsequent updates to this
class where to try and fix bugs related to this patch. Given that , I tried
reverting back to just before this patch and all our sql server problems
related to the protocal streams have gone away and all our sql server
persistence tests now work. 

Given this is just a performance patch, could we just revert this patch and the
subseqent patches that try to fix issues around this patch. If you want to
reintroduce this performance patch , maybe you could send patches for us to try
and verify. Maybe introduce small changes to help isolate probelms given the
complexity of this code. 

Im not a git expert so Im not sure how to do the revert but I could try and do
the revert and send the patch to you if need be given that this is a critical
problem since we are still on mono 2.4 because of all the problems with the
patch and we really really need to get onto the mono 2.10.

thanks
scott

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.