[Mono-bugs] [Bug 699948] New: Typo in `div128by32' in decimal.c

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=699948

https://bugzilla.novell.com/show_bug.cgi?id=699948#c0


           Summary: Typo in `div128by32' in decimal.c
    Classification: Mono
           Product: Mono: Class Libraries
           Version: SVN
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: P5 - None
         Component: CORLIB
        AssignedTo: mono-bugs at lists.ximian.com
        ReportedBy: manus at eiffel.com
         QAContact: mono-bugs at lists.ximian.com
          Found By: ---
           Blocker: ---


I believe the Line 360 of decimal.c for the routine `div128by32' should read:

    return (a > factor || (a == factor && (c & 1) == 1)) ? 1 : 0;

instead of

    return (a >= factor || (a == factor && (c & 1) == 1)) ? 1 : 0;

as otherwise it could be simplified in just

    return (a >= factor) ? 1 : 0;

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.