[Mono-bugs] [Bug 670619] Softdebugger hangs on ThreadMirror.GetFrames

[bugzilla_noreply at novell.com]

https://bugzilla.novell.com/show_bug.cgi?id=670619

https://bugzilla.novell.com/show_bug.cgi?id=670619#c5


--- Comment #5 from Zoltan Varga <vargaz at gmail.com> 2011-02-11 01:04:09 UTC ---
The following patch appears to fix it:

<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<
diff --git a/mono/metadata/gc.c b/mono/metadata/gc.c
index 3318391..1580d82 100644
--- a/mono/metadata/gc.c
+++ b/mono/metadata/gc.c
@@ -1060,7 +1060,8 @@ finalizer_thread (gpointer unused)
         g_assert (mono_domain_get () == mono_get_root_domain ());

 #ifdef MONO_HAS_SEMAPHORES
-        MONO_SEM_WAIT (&finalizer_sem);
+        /* An alertable wait is required so this thread can be suspended on
windows */
+        MONO_SEM_WAIT_ALERTABLE (&finalizer_sem, TRUE);
 #else
         /* Use alertable=FALSE since we will be asked to exit using the event
too */
         WaitForSingleObjectEx (finalizer_event, INFINITE, FALSE);
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

I'll check it in, just have to investigate the 'Use alertable=FALSE' comment
which was written by yours truly in 2006 :).

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.