[Mono-bugs] [Bug 599841] TabControl / TabPage Text and Image should be centered when SizeMode = Fixed

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=599841

http://bugzilla.novell.com/show_bug.cgi?id=599841#c14


--- Comment #14 from Carlos Alberto Cortez <calberto.cortez at gmail.com> 2010-05-16 22:14:45 UTC ---
The alignment fixes for the text have been applied as part of rev 157406. The
part of the image seems correct as well, but I'm wondering about this part:


                    if (is_selected) {
+                        // Reduce the interior size to match the inner size of
non-selected tabs
+                        str_rect.X += selectedTabDelta.X;
+                        str_rect.Y += selectedTabDelta.Y;
+                        str_rect.Width -= selectedTabDelta.Width;
+                        str_rect.Height -= selectedTabDelta.Height;
+
+                        str_rect.Offset(0, -2); // Move up the text / image of
the selected tab
+                    }
+

Basically I can't see a big difference with it - we are also already applying
some offsets for the selected tab, as far as I remember, so I think this is not
needed. It's just a very, very minor difference and we would end up having a
lot of patches like these for all winforms :-)

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.