[Mono-bugs] [Bug 599841] TabControl / TabPage Text and Image should be centered when SizeMode = Fixed

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=599841

http://bugzilla.novell.com/show_bug.cgi?id=599841#c12


Thomas Goldstein <stifu at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357563|0                           |1
        is obsolete|                            |

--- Comment #12 from Thomas Goldstein <stifu at free.fr> 2010-05-08 12:04:42 UTC ---
Created an attachment (id=360642)
 --> (http://bugzilla.novell.com/attachment.cgi?id=360642)
Patch 4

Here's a new patch which fixes the issue mentioned above.

So, to sum things up, in the end, this is what this patch fixes:

- Tab text is vertically centered (images were already properly vertically
centered)
- Tab text and/or image are horizontally centered when in SizeMode = Fixed
- The text and/or image of the selected tab is now moved up by 2px, as .NET
does

Note that I've fixed these issues that I found for TabControl with Alignment =
Top (the default TabControl Alignment), but didn't fix anything for the other
Alignment modes (but didn't notice regressions).

Also, bothered by the fact that the selected tab had a bigger Rectangle (as
this shifts the text and images drawn on it), I decided to shrink the Rectangle
right before writing the text and/or image, so that it's just like the other
tabs (an alternative could have been to use 2 different Rectangles to draw the
tab and its content, I guess).

Consequently, the bug I mentioned above about tab texts being truncated
sometimes (happens in the test case above) now also appears on the selected
tab, not just on non-selected tabs. Would you see this as a regression that
would block this patch? It's not actually a new bug, but one which is more
obvious / appears consistently now.

I'm not sure yet, but I think this truncated text bug might be related to the
Padding bugs. But I didn't want to commit a huge patch, and wanted to tackle
this one step at a time. Other issues can be handled separately.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.