[Mono-bugs] [Bug 622401] New: Conflicting compiler definitions in TimeZoneInfo.cs

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=622401

http://bugzilla.novell.com/show_bug.cgi?id=622401#c0


           Summary: Conflicting compiler definitions in TimeZoneInfo.cs
    Classification: Mono
           Product: Mono: Class Libraries
           Version: SVN
          Platform: Other
        OS/Version: Windows
            Status: NEW
          Severity: Minor
          Priority: P5 - None
         Component: Sys.Core
        AssignedTo: mono-bugs at lists.ximian.com
        ReportedBy: phil at thinkedge.com
         QAContact: mono-bugs at lists.ximian.com
          Found By: Development
           Blocker: No


I want to bring your attention to a problem I noticed with revision r159234:

In TimeZoneInfo.cs, the following method is wrapped in a #if LIBC

static List<AdjustmentRule> ValidateRules (List<AdjustmentRule>
adjustmentRules)

but it's called by the following method which is outside any #if LIBC define:

private static TimeZoneInfo FromRegistryKey (string id, RegistryKey key)

This causes a compiler error when LIBC is not define and not targeting
Moonlight (!NET_2_1).

I believe the fix is to move ValidateRules method outside of #if LIBC or wrap
the FromRegistryKey method also within a #if LIBC.

I only noticed this because I'm compiling a modified version of the Mono class
libraries for the Mosa project where LIBC is not defined and not targeting
Moonlight. So it might not show up during the normal Mono build process. 

For our purposes, it would be helpful to have this fixed. Thanks.

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.