[Mono-bugs] [Bug 605545] Add support of string resources to ProvideCorrectArgumentsToFormattingMethodsRule

[bugzilla_noreply at novell.com]

http://bugzilla.novell.com/show_bug.cgi?id=605545

http://bugzilla.novell.com/show_bug.cgi?id=605545#c3


--- Comment #3 from Antoine Vandecrème <avandecreme at sopragroup.com> 2010-07-04 14:43:49 UTC ---
Created an attachment (id=373717)
 --> (http://bugzilla.novell.com/attachment.cgi?id=373717)
fix remarks

Here is a new patch fixing the previous remarks.

This patch produces new gendarme defects :

-AvoidCodeDuplicatedInSameClassRule : 
I don't know why this rule fired.
Maybe because there is in both method a line like :
MethodReference mr = (call.Operand as MethodReference);


-PreferEmptyInstanceOverNullRule :
I really need to return null and not String.Empty because null means the string
resource is not found. A String.Empty value means the string found is
string.Empty.
I don't know what is the best practice here. Maybe method such as :
bool TryGetString(out string result)

-- 
Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.