[Mono-bugs] [Bug 478489] System.IO.Path.GetDirectoryName does not throw exception for the value ":C/"

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Mon Dec 20 18:05:18 EST 2010


https://bugzilla.novell.com/show_bug.cgi?id=478489

https://bugzilla.novell.com/show_bug.cgi?id=478489#c7


Robert Jordan <robertj at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robertj at gmx.net

--- Comment #7 from Robert Jordan <robertj at gmx.net> 2010-12-20 23:05:17 UTC ---
> Diff for Path.cs file

- there is a redundant and costly split on DirectorySeparatorChar

- ':' is invalid everywhere but at path[1] and only if path[0] is a-z.
  The patch does not test for this.

- unit tests are missing

- source code formatting issues (space vs. tabs)

-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the mono-bugs mailing list