[Mono-bugs] [Bug 605545] Add support of string resources to ProvideCorrectArgumentsToFormattingMethodsRule

bugzilla_noreply at novell.com bugzilla_noreply at novell.com
Fri Aug 6 11:12:50 EDT 2010



Sebastien Pouliot <spouliot at novell.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
                 CC|                            |spouliot at novell.com
         Resolution|                            |FIXED

--- Comment #4 from Sebastien Pouliot <spouliot at novell.com> 2010-08-06 15:12:49 UTC ---
Bonjour Antoine,

I don't get the failure from AvoidCodeDuplicatedInSameClassRule - that's likely
a windows-only (well CSC) defect. I guess I'll spot it later when I go back to
a windows VM.

As for the PreferEmptyInstanceOverNullRule defects I added new ignore entries
for them (there are already some similar to this).

I also made a few, mostly minor, changes:

GetLoadStringFormatInstruction: Use a swicth/case to add Callvirt (since some
compilers use callvirt even when a call would be valid).

GetResourceNameFromResourceGetter: Added a comment about this working only for
generated code

GetLoadStringFromCall: Change signature and avoid calling Resolve 2 times on a

IsResource: Use IsGetter property instead of IsProperty method (faster and more

and, finally, I added your name to the rule and tests authors and in Gendarme's
main AUTHORS file :-)

pushed as b1a5eb301e9847100c9a018ccd09123d1bde44b0 on master

Configure bugmail: http://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the mono-bugs mailing list